[DEV] Refactor DatabaseConfig usages in reconcile runtime and tests#2503
Open
BesikiML wants to merge 2 commits into
Open
[DEV] Refactor DatabaseConfig usages in reconcile runtime and tests#2503BesikiML wants to merge 2 commits into
BesikiML wants to merge 2 commits into
Conversation
…onnection configs Replace DatabaseConfig usage across reconcile runtime paths with SourceConnectionConfig and TargetConnectionConfig, update service wiring and integration tests, and keep ReconCapture backward-compatible for legacy constructor callers during migration.
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
==========================================
- Coverage 67.00% 66.82% -0.18%
==========================================
Files 107 107
Lines 9950 9978 +28
Branches 1071 1076 +5
==========================================
+ Hits 6667 6668 +1
- Misses 3087 3114 +27
Partials 196 196 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
❌ 171/172 passed, 6 flaky, 1 failed, 2 skipped, 53m1s total ❌ test_reconcile_aggregate_data_mismatch_and_missing_records: ValueError: uc_connection_name is required for non-databricks sources (dialect=snowflake) (912ms)Flaky tests:
Running from acceptance #4800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SourceConnectionConfigandTargetConnectionConfiginstead ofDatabaseConfig.Reconciliation,TriggerReconService, andTriggerReconAggregateServiceto pass source/target connection config objects explicitly.DatabaseConfigusage fromtests/integration/reconcile/test_recon_capture.py.Backward Compatibility
ReconCaptureconstructor compatibility for legacyDatabaseConfig-style callers during the migration period.Validation
uv run python -m pytest tests/integration/reconcile/test_recon_capture.py -q23 skippeduv run python -m pytest tests/integration/reconcile/query_builder/test_execute.py -q1 passed, 15 skippeduv run python -m pytest tests/integration/reconcile/test_aggregates_reconcile.py -q4 passed, 2 skippeduv run python -m pytest tests/integration/reconcile/test_aggregates_recon_capture.py -q1 skippedNotes
uv.lockchanges from local environment sync were intentionally excluded from this PR.Linked issues
Fixed issue : #2417
Tests